Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] [stable28] perf(rich_workspace): only add property for parent #5960

Closed
wants to merge 1 commit into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 27, 2024

Draft on 28, just because I was investigating on 28. I'll recreate on main soon

📝 Summary

Steps to reproduce

  1. Add 300-500 s3 external storages and mount to root subfolder
  2. Enable text
  3. See 10-15s loading time on /apps/files/files for PROPFIND request. On real instance it could be up to 90 seconds for 300 storages
s3 28 27
0 0.1s 0.1s
100 3s 0.2s
200 6s 0.5s
300 9s 0.9s
400 12s 1-2s
500 15s 1.1-2.4s

A problem

There is a new <nc:rich_workspace> property for each Node in the response.

After disabling Text or disabling rich_workspace the problem disappears.

🚧 TODO

  • only add property for parent ignoring deep nodes as it was in past

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@mejo-
Copy link
Member

mejo- commented Jul 25, 2024

@ShGKme this PR probably can be closed in favour of #5963, no?

@ShGKme ShGKme closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants